Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop memcpy-ing internal data structures into packets. #2595

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 24, 2024

This change is Reviewable

@iphydf iphydf added this to the v0.2.19 milestone Jan 24, 2024
@iphydf iphydf force-pushed the random-padding branch 9 times, most recently from 39e570b to 0912c60 Compare January 29, 2024 23:24
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.66%. Comparing base (7b1db6a) to head (0754390).

❗ Current head 0754390 differs from pull request most recent head dd45f9e. Consider uploading reports for the commit dd45f9e to get more accurate results

Files Patch % Lines
toxcore/DHT.c 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2595      +/-   ##
==========================================
+ Coverage   73.13%   73.66%   +0.53%     
==========================================
  Files         149      148       -1     
  Lines       30516    30417      -99     
==========================================
+ Hits        22317    22406      +89     
+ Misses       8199     8011     -188     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf marked this pull request as ready for review January 30, 2024 10:15
@iphydf iphydf force-pushed the random-padding branch 5 times, most recently from 944aa9c to 9ce17ef Compare January 30, 2024 22:14
@iphydf iphydf marked this pull request as draft January 30, 2024 22:48
@iphydf iphydf force-pushed the random-padding branch 4 times, most recently from 236d474 to c93ccdd Compare February 2, 2024 23:51
@iphydf iphydf modified the milestones: v0.2.19, v0.2.20 Feb 11, 2024
@iphydf iphydf force-pushed the random-padding branch 3 times, most recently from 8dd8fef to cd0da14 Compare February 14, 2024 22:00
@iphydf iphydf force-pushed the random-padding branch 2 times, most recently from d37c54b to 87c48e9 Compare March 5, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant