refactor: Make ToxAV independent of toxcore internals. #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2651 +/- ##
==========================================
- Coverage 73.08% 73.04% -0.04%
==========================================
Files 149 149
Lines 30531 30479 -52
==========================================
- Hits 22313 22264 -49
+ Misses 8218 8215 -3 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
toxav-public-api
branch
2 times, most recently
from
e59814d
to
8a4092b
Compare
|
This is ready for review. |
iphydf
force-pushed
the
toxav-public-api
branch
from
8a4092b
to
55a8294
Compare
iphydf
force-pushed
the
toxav-public-api
branch
from
e0896da
to
756ee54
Compare
iphydf
force-pushed
the
toxav-public-api
branch
2 times, most recently
from
eb8a05a
to
5b737a8
Compare
Green-Sky
reviewed
Apr 27, 2024
Green-Sky
reviewed
Apr 27, 2024
Green-Sky
force-pushed
the
toxav-public-api
branch
from
5b737a8
to
59d3feb
Compare
Green-Sky
force-pushed
the
toxav-public-api
branch
2 times, most recently
from
664ee5f
to
560cd96
Compare
Green-Sky
requested changes
Sep 18, 2024
| free(session); | ||
| return nullptr; | ||
| } | ||
|
|
||
| // First entry is free. | ||
| session->work_buffer_list->next_free_entry = 0; | ||
|
|
||
| session->ssrc = payload_type == RTP_TYPE_VIDEO ? 0 : random_u32(m->rng); | ||
| session->ssrc = payload_type == RTP_TYPE_VIDEO ? 0 : rtp_random_u32(); // Zoff: what is this?? |
There was a problem hiding this comment.
according to https://www.rfc-editor.org/rfc/rfc3550 , this is used to disambiguate multiple sessions. However we don't use this (yet?).
| rc = TOXAV_ERR_NEW_MALLOC; | ||
| goto RETURN; | ||
| } | ||
|
|
||
| av->log = tox->m->log; |
Green-Sky
force-pushed
the
toxav-public-api
branch
from
dac5f88
to
d4978a3
Compare
Green-Sky
requested changes
Sep 20, 2024
|
|
||
| if (length - 1 != sizeof(struct BWCMessage)) { | ||
| return -1; | ||
| LOGGER_ERROR(log, "Actual data size and length argument do not match"); |
There was a problem hiding this comment.
sizeof(struct xxx) is an unreliable number that's implementation defined. We want 2 u32 instead.
Also, the log reads kinda wrong.
| @@ -5,19 +5,24 @@ | |||
| #ifndef C_TOXCORE_TOXAV_BWCONTROLLER_H | |||
| #define C_TOXCORE_TOXAV_BWCONTROLLER_H | |||
|
|
|||
| #include "../toxcore/Messenger.h" | |||
| #include <stdint.h> | |||
There was a problem hiding this comment.
standard headers always after your own headers.
There was a problem hiding this comment.
I just realized that this problem plagues the whole of toxcore <.<
| typedef void m_msi_packet_cb(Messenger *m, uint32_t friend_number, const uint8_t *data, uint16_t length, | ||
| void *user_data); | ||
| typedef int m_lossy_rtp_packet_cb(Messenger *m, uint32_t friend_number, const uint8_t *data, uint16_t length, void *object); | ||
| typedef int m_lossy_rtp_packet_cb(Messenger *m, uint32_t friend_number, const uint8_t *data, uint16_t len, void *object); |
Green-Sky
force-pushed
the
toxav-public-api
branch
from
d4978a3
to
3297b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is