chore: Check if TCP test is fixed on NetBSD #2730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2730 +/- ##
==========================================
- Coverage 73.14% 73.00% -0.14%
==========================================
Files 149 149
Lines 30516 30516
==========================================
- Hits 22320 22279 -41
- Misses 8196 8237 +41 ☔ View full report in Codecov by Sentry. |
|
Nope, that didn't fix it, it times out after 500 seconds, probably getting stuck somewhere. |
|
Tip: the TCP test only has a debug logger for the first test, all other tests have an empty logger, so for better debugging in ci, we should enable those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just want to run the CI to see if perhaps #2369 fixed the TCP test on NetBSD.
This change is