Skip to content

feat: implement the last 2 missing network struct functions

Mergeable / Mergeable succeeded Oct 12, 2024 in 0s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : feat: implement the last 2 missing network struct functions
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\(\\w+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : feat: implement the last 2 missing network struct functions
    and make use of them
    Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\(\\w+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : - [x] implement getaddrinfo and freeaddrinfo
  • replace all uses of getaddrinfo()
    • addr_resolve()
    • net_getipport()
  • separate out the network struct from network.h/c
  • test os_network_no_dns()

This pr finally allows us to implement a regression test for #2361


This pr implements a different approach to disabling DNS, compared to #2694, here we can simply replace the functions pointers in the network struct with dummies/stubs.


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}