Introduce the LRE flake overlay #1516
Conversation
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
had a problem deploying
to
production
GitHub Actions
Error
This change migrates the last patch to an overlay and removes the patch structure. This resolves all IFDs, cleans up the main flake and makes our custom toolchains portable across flakes. The `customClang` and `customStdenv` packages are now available as `lre.clang` and `lre.stdenv`. While the new packages are differently named, they produce the exact same setup as previously. This can be verified by the fact that `generate-toolchains` is a noop between the previous commit and this one. Since a renaming of the `customClang` executable itself would cause differences in the lre-cc toolchain we defer this to a future commit. Fixes TraceMachina#1262 Closes TraceMachina#1512
aaronmondal
force-pushed
the
migrate-llvm-patch
branch
from
74a2ba9 to
99f93cb
Compare
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 7 files reviewed, and pending CI: Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Coverage, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, Web Platform Deployment / macos-14, Web Platform Deployment / ubuntu-24.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, windows-2022 / stable (waiting on @SchahinRohani)
There was a problem hiding this comment.
Great work!
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Bazel Dev / macos-13, Cargo Dev / macos-13, Coverage, Installation / macos-13, Remote / large-ubuntu-22.04
This change migrates the last patch to an overlay and removes the patch structure. This resolves all IFDs, cleans up the main flake and makes our custom toolchains portable across flakes.
The
customClangandcustomStdenvpackages are now available aslre.clangandlre.stdenv.While the new packages are differently named, they produce the exact same setup as previously. This can be verified by the fact that
generate-toolchainsis a noop between the previous commit and this one.Since a renaming of the
customClangexecutable itself would cause differences in the lre-cc toolchain we defer this to a future commit.Fixes #1262
Closes #1512
This change is