Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take 3 🎬 Fix Protected Users check #119

Merged

Conversation

SamErde
Copy link
Collaborator

@SamErde SamErde commented Feb 26, 2024

Uploaded a renamed, working Protected Users check.

The rename aligns the PS1 filename with the function name.
I fixed a gap in the SID matching and also added a check for primaryGroupID (525).

The function is maintained at https://github.com/samerde/active-directory.

Uploaded a renamed, working Protected Users check.

The rename aligns the PS1 filename with the function name.
I fixed a gap in the SID matching and also added a check for primaryGroupID (525).

The function is maintained at https://github.com/samerde/active-directory.
Renamed to align with function name
@SamErde SamErde added the bug Something isn't working label Feb 26, 2024
@SamErde SamErde self-assigned this Feb 26, 2024
@SamErde SamErde requested a review from TrimarcJake February 26, 2024 22:24
Copy link
Owner

@TrimarcJake TrimarcJake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACTION!

@TrimarcJake TrimarcJake merged commit 7871269 into TrimarcJake:testing Feb 27, 2024
3 checks passed
@SamErde SamErde deleted the SamErde-Fix-ProtectedUserCheck-02 branch February 27, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants