Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Se simple empty array check 01 #183

Closed
wants to merge 10 commits into from
Closed

Se simple empty array check 01 #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d5d2ee4
Update README.md
TrimarcJake Nov 10, 2024
e867174
Update Invoke-Scans.ps1
SamErde Nov 11, 2024
fe3ed69
Merge pull request #181 from TrimarcJake/SamErde-patch-1
SamErde Nov 11, 2024
8f60273
Merge branch 'testing' into main
TrimarcJake Nov 11, 2024
59af8e6
Replace individual issue checks with one simple check.
SamErde Nov 11, 2024
7bb1b1b
Merge branch 'testing' into se-simple-empty-array-check-01
SamErde Nov 11, 2024
d66b5cd
Build
TrimarcJake Nov 11, 2024
e977f98
Ope. Cut out the Packed version by mistake.
TrimarcJake Nov 13, 2024
d932147
Merge branch 'TrimarcJake:main' into se-simple-empty-array-check-01
SamErde Nov 14, 2024
032ea76
Merge branch 'testing' into se-simple-empty-array-check-01
TrimarcJake Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Build/Build-Module.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,7 @@ Build-Module -ModuleName 'Locksmith' {

New-ConfigurationArtefact -Type Packed -Enable -Path "$PSScriptRoot\..\Artefacts\Packed" -ArtefactName '<ModuleName>.zip'
New-ConfigurationArtefact -Type Script -Enable -Path "$PSScriptRoot\..\Artefacts\Script" -PreScriptMerge $PreScriptMerge -PostScriptMerge $PostScriptMerge -ScriptName "Invoke-<ModuleName>.ps1"
New-ConfigurationArtefact -Type ScriptPacked -Enable -Path "$PSScriptRoot\..\Artefacts\ScriptPacked" -ArtefactName "Invoke-<ModuleName>.zip" -PreScriptMerge $PreScriptMerge -PostScriptMerge $PostScriptMerge -ScriptName "Invoke-<ModuleName>.ps1"
New-ConfigurationArtefact -Type Unpacked -Enable -Path "$PSScriptRoot\..\Artefacts\Unpacked"
New-ConfigurationArtefact -Type ScriptPacked -Enable -Path "$PSScriptRoot\..\Artefacts\ScriptPacked" -PreScriptMerge $PreScriptMerge -PostScriptMerge $PostScriptMerge -ScriptName 'Invoke-<ModuleName>.ps1' -ArtefactName 'Invoke-<ModuleName>.zip'
# New-ConfigurationPublish -Type PowerShellGallery -FilePath 'C:\Users\jake.BLUETUXEDO\Documents\API Keys\PSGallery.txt'
}

Expand Down
4 changes: 2 additions & 2 deletions Invoke-Locksmith.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2224,7 +2224,7 @@ function Invoke-Scans {
[array]$AllIssues = $AuditingIssues + $ESC1 + $ESC2 + $ESC3 + $ESC4 + $ESC5 + $ESC6 + $ESC8 + $ESC11 + $ESC13

# If these are all empty = no issues found, exit
if ((!$AuditingIssues) -and (!$ESC1) -and (!$ESC2) -and (!$ESC3) -and (!$ESC4) -and (!$ESC5) -and (!$ESC6) -and (!$ESC8) -and ($ESC11) -and ($ESC13) ) {
if ((!$AuditingIssues) -and (!$ESC1) -and (!$ESC2) -and (!$ESC3) -and (!$ESC4) -and (!$ESC5) -and (!$ESC6) -and (!$ESC8) -and (!$ESC11) -and (!$ESC13) ) {
Write-Host "`n$(Get-Date) : No ADCS issues were found." -ForegroundColor Green
break
}
Expand Down Expand Up @@ -3229,7 +3229,7 @@ function Invoke-Locksmith {
[System.Management.Automation.PSCredential]$Credential
)

$Version = '2024.11.10'
$Version = '2024.11.11'
$LogoPart1 = @"
_ _____ _______ _ _ _______ _______ _____ _______ _ _
| | | | |____/ |______ | | | | | |_____|
Expand Down
2 changes: 1 addition & 1 deletion Locksmith.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
Description = 'A small tool to find and fix common misconfigurations in Active Directory Certificate Services.'
FunctionsToExport = @('*')
GUID = 'b1325b42-8dc4-4f17-aa1f-dcb5984ca14a'
ModuleVersion = '2024.11.10'
ModuleVersion = '2024.11.11'
PowerShellVersion = '5.1'
PrivateData = @{
PSData = @{
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ A ~~tiny~~ small tool built to find and fix common misconfigurations in Active D
1. Open a PowerShell prompt and run `Install-Module -Name Locksmith -Scope CurrentUser`

### Install module manually from GitHub:
1. Download the [latest module version](https://github.com/TrimarcJake/Locksmith/releases/latest) ( **Locksmith-v**\<YEAR\>**.**\<MONTH\>**.zip** )
1. Download the latest module version: [https://github.com/TrimarcJake/Locksmith/releases/latest/download/Locksmith.zip](https://github.com/TrimarcJake/Locksmith/releases/latest/download/Locksmith.zip)
2. Extract the downloaded zip file
3. Open a PowerShell prompt to the location of the extracted file and run `Import-Module .\Locksmith.psd1`

Expand Down
Loading