Bug fixes for the FACTS method #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: phantom-duck <37215464+phantom-duck@users.noreply.github.com>
this part of the code is problematic due to the use of hardcoded feature names. The required functionality should be achieved in some other way. Signed-off-by: phantom-duck <37215464+phantom-duck@users.noreply.github.com>
Signed-off-by: phantom-duck <37215464+phantom-duck@users.noreply.github.com>
Signed-off-by: phantom-duck <37215464+phantom-duck@users.noreply.github.com>
|
Hello! Thanks for the feedback. Apologies for the delayed response.
Ok, great, we will see to it as soon as possible and create a new PR.
Of course. So this one I will add to this PR right? |
Yes, please 🙂 |
Signed-off-by: phantom-duck <37215464+phantom-duck@users.noreply.github.com>
Previously, the test case only had inf costs. Consequently, the exact values of the feature weights were not actually tested properly. Signed-off-by: phantom-duck <37215464+phantom-duck@users.noreply.github.com>
|
Hello again @hoffmansc ! I have now added a test showcasing that the costs are computed correctly (close to the example in #532). Just a question to be sure I understood correctly, is this what you meant? Or by "test case" you mean also to add something to the example notebook for example? Other than, I think we are good to go. |
|
This is perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hoffmansc
Wrote fixes for the bugs documented in issues #531 and #532.
For the issue of the hard-coded features in the
recIsValidfunction (issue #531, code here), the fix currently proposed is a hotfix. The values have not been removed, only the relevant argument's default value has been changed fromTruetoFalse.Whether you would like us to remove this part of the code altogether or keep working on it to make it more robust (and if so, in this pull request or a new one), please let me know.
Fixes #531 and #532.