Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite it #758

Merged
merged 64 commits into from
Aug 22, 2023
Merged

Rewrite it #758

merged 64 commits into from
Aug 22, 2023

Conversation

GarboMuffin
Copy link
Member

@GarboMuffin GarboMuffin commented Aug 18, 2023

The changes:

  • Sensitive pages no longer use file:// (we will need one file:// for migration unfortunately)
  • Most pages use separate protocols entirely so eg. packager and editor won't misbehave with eachother
  • IPC, permissions, and preload are now per-window
  • Renderer processes no longer receive full paths (just names and numbers)
  • Clamped down preload scripts to only expose what's actually needed, not the entire IPC surface area
  • L10N strings now use structured JSON so we can add context

What's missing:

  • custom confirm() alert() because Electron vanilla are still broken
  • offline library files
  • offline extensions
  • window background colors
  • escape to close subwindows, also make sure it doesnt interfere with fullscreen escape
  • addon splash dark mode
  • update download dialogs
  • new update checker
  • selected microphone
  • selected camera
  • hardware acceleration toggle
  • sleep hidden windows toggle
  • bypass CORS toggle
  • open user data button
  • content security policies
  • userscript & userstyle
  • update privacy policy
  • desktop settings warnings
  • remember last accessed directory and migrate old
  • listen for locale changes in renderer, forward to main, persist, migrate old
  • handle what happens when the migrate window is closed
  • packager preview
  • load project by URL
  • test mailto:
  • username
  • scratch link DNS?
  • mac test 1: selected microphone was blank, disabled update checker did not migrate
  • prompt()
  • detect ARM translation
  • handle create data: window?
  • test represented file & changed on macOS
  • Update CI
  • make sure that windows really really do not navigate
  • test file opening on macOS
  • selected microphone and camera actually wont work right now, ids differ between origins
  • l10n in renderers
  • normalize.css
  • remove debug logging
  • Put the entire extension gallery into the library scratch-gui#804
  • migrating old settings and such (very scary)
  • a whole bunch of testing

@GarboMuffin GarboMuffin changed the title Rewrite it all from the ground up Rewrite it Aug 18, 2023
@GarboMuffin GarboMuffin marked this pull request as ready for review August 22, 2023 02:01
@GarboMuffin GarboMuffin merged commit 9e3a35b into master Aug 22, 2023
1 check passed
@GarboMuffin GarboMuffin deleted the rewrite branch August 22, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant