Change typescript to depend on source instead of built files #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfedderly
commented
Aug 7, 2024
| @@ -331,7 +331,7 @@ const turfTypescriptPath = path.join(__dirname, "..", "turf-*", "index.d.ts"); | |||
|
|
|||
| // Test Strings | |||
| const requireString = `import test from 'tape'; | |||
| import * as turf from './dist/esm/index.js'; | |||
| import * as turf from './index.ts'; | |||
There was a problem hiding this comment.
Jumping into the built output gets us away from the tsconfig paths settings, so we have to hit the index.ts instead.
| @@ -10,6 +10,7 @@ packages/turf-directional-mean/test/in/bus_route_utm.json | |||
|
|
|||
| # is actually output | |||
| packages/turf/turf.min.js | |||
| packages/turf/test.example.js | |||
There was a problem hiding this comment.
I think this will help with rerunnability locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal version of #2682
There's an issue where it doesn't leave the imports in the built code.