auto-generate list of Units and AreaUnits and link all modules with units param #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twelch
changed the title
2 tasks
mfedderly
reviewed
Aug 9, 2024
| @@ -33,6 +33,7 @@ | |||
| "@monorepolint/config": "0.5.0-alpha.132", | |||
| "@monorepolint/core": "0.5.0-alpha.132", | |||
| "@monorepolint/rules": "0.5.0-alpha.132", | |||
| "@phenomnomnominal/tsquery": "6.1.3", | |||
There was a problem hiding this comment.
ts-morph would be the alternative library here if you decide you don't like tsquery, I don't have a strong opinion here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1298
Builds on #2683
ToDo
unitsparameters to link to this README. Make sure the functions actually support all units.Feedback is welcome on approach of using the tsquery module to query and build a master list of supported Units and AreaUnits, as part of the generate-readmes.ts script run by CI. tsquery is a relatively easy-to-use AST/query tool that is different from the AST that documentation.js produces, which I think using Babel. I think this will be easier to maintain.