Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CompatHelper.yml #105

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Update CompatHelper.yml #105

merged 1 commit into from
Oct 8, 2024

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Oct 6, 2024

replacing the old COMPATHELPER_PRIV ssh key with the new DOCUMENTER_KEY (i suspect that's what's stopping CompatHelper PRs from triggering CI, as it doesn't seem to have an associated deploy key)

see e.g. #104

@penelopeysm penelopeysm requested a review from mhauru October 7, 2024 12:23
@mhauru
Copy link
Member

mhauru commented Oct 8, 2024

So we used to have two secret SSH keys, one for CompatHelper and one for Documenter. And something has happened to the former (expired?) and thus this PR starts using the latter for CompatHelper as well? Any reason to not add another key CompatHelper? Just a faff, and this gets it done easier? Excuse the volley of questions, just want to make sure I understand what's going on here.

@penelopeysm
Copy link
Member Author

And something has happened to the former (expired?) and thus this PR starts using the latter for CompatHelper as well?

I don't entirely know what happened to make it no longer work, but my suspicion is that GitHub permission-y stuff changed (new changes happen with surprising frequency).

Any reason to not add another key CompatHelper? Just a faff, and this gets it done easier?

Getting CompatHelper and Documenter to share an SSH key is pretty much the way everyone does it nowadays in Julia (including the CompatHelper repo itself 😅), most of the repos in TuringLang follow this pattern too.

Excuse the volley of questions, just want to make sure I understand what's going on here.

No problem :D

Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if that's how CompatHelper itself does it...

@penelopeysm penelopeysm merged commit 7af5cf5 into main Oct 8, 2024
12 checks passed
@penelopeysm penelopeysm deleted the py/gha branch October 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants