Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for application blacklist #344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dainius14
Copy link

You're not allowing to create issues as feature requests, so I'm creating a PR for a feature I need myself.

This feature adds a new "blacklist" alongside whitelist. Blacklist would force LightBulb to run even when "Pause in fullscreen" is enabled. Reason for such a feature: I have pause in fullscreen enabled, so I can watch YT or game without orange tint. But I also work via RDP, so from the perspective of LightBulb I'm fullscreen and orange tint is not enabled because of the first setting.

Updated UI:
image

Points for discussion:

  1. Whitelist and blacklist names should be switched. Currently adding an app to whitelist will disable LightBulb for that app, but that seems like definition of "blacklist" - to exclude something. Right now it feels strange to blacklist an app for it to always be tinted.
  2. No unit tests? Should I introduce some? Feels weird without them. Would need some minor refactoring though, could introduce that in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant