Skip to content

Commit

Permalink
Merge pull request #17 from UBC-MDS/integration
Browse files Browse the repository at this point in the history
Revised description to add missing package, revise typos in data cleaner example
  • Loading branch information
elabandari authored Mar 13, 2021
2 parents 9e780a0 + 6b6e683 commit f00605e
Show file tree
Hide file tree
Showing 5 changed files with 997 additions and 1,008 deletions.
8 changes: 2 additions & 6 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.1
URL: https://github.com/elina-linglin/Rhousehunter
BugReports: https://github.com/elina-linglin/Rhousehunter/issues

Config/testthat/edition: 3
Imports:
polite,
Expand All @@ -32,8 +31,5 @@ Imports:
testthat,
dplyr,
stringr,
httr

Suggests:
testthat (>= 3.0.0)

httr,
readr
2 changes: 1 addition & 1 deletion NAMESPACE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Generated by roxygen2: do not edit by hand

export(scraper)
export(data_cleaner)
export(data_filter)
export(scraper)
export(send_email)
6 changes: 3 additions & 3 deletions R/data_cleaner.R
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@
#' @return tibble A cleaned tibble containing information like listing url, price, number of bedrooms, area in sqft, and city.
#' @export
#' @examples
#' data_cleaner(tibble::tibble(price= c($1,300", $1,200"), house_type= c(1br-600ft2-“, “2br-),
#' listing_url = c(“https://vancouver.craigslist.org/bnc/apa/d/burnaby-must-see-1br-suite/7282955370.html,
#' https://vancouver.craigslist.org/rds/apa/d/surrey-bedroom-basement-for-rent/7273877138.html)))
#' data_cleaner(tibble::tibble("price"= c("$1,300", "$1,200"), "house_type"= c("1br-600ft2-", "2br-"),
#' "listing_url" = c(“https://vancouver.craigslist.org/bnc/apa/d/burnaby-must-see-1br-suite/7282955370.html",
#' "https://vancouver.craigslist.org/rds/apa/d/surrey-bedroom-basement-for-rent/7273877138.html")))
data_cleaner <- function(scraped_df) {
if (!tibble::is_tibble(scraped_df)) {
stop("Cannot do the data cleaning for a non-tibble input")
Expand Down
3 changes: 0 additions & 3 deletions man/data_cleaner.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit f00605e

Please sign in to comment.