Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH Clones Needing Explicit Directory Name #10

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

willGraham01
Copy link
Contributor

What is this PR?

  • Bug fix 🐛
  • Addition of a new feature 🚀
  • Documentation update 📃
  • CI / infrastructure improvement 🔧
  • Other 🤷

Why is this PR needed?

Cloning from GH via GitPython places the repository root in the target directory, it does not create a new directory with the repository name and insert it into the target directory.

This was causing the -g option to flag submissions as incorrect because the top-level folder did not match the expected naming pattern.

What does this PR do?

Repos that are fetched from GitHub now have their name inferred, and are relocated to a temporary directory with this name.

How has this PR been tested?

Is this a breaking change?

Checklist

  • The code introduced in this PR has been tested locally.
  • Appropriate tests have been added to cover any new functionality.
  • The documentation has been updated to reflect any changes.
  • The code has been formatted with pre-commit.

@willGraham01 willGraham01 merged commit a00ba26 into main Nov 1, 2024
9 checks passed
@willGraham01 willGraham01 deleted the fix_gh_cloning_issue branch November 1, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant