Issue#24 current year coherency #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonygego
requested changes
Sep 26, 2024
| @config_bp.route('/next_year', methods=['POST']) | ||
| @login_required | ||
| @check_access_level(Role.ADMIN) | ||
| def next_year(): |
There was a problem hiding this comment.
@luciledierckx Using this implementation we'll always be going in one way. Is there any case for which we'd like to revert and go to the past ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current year was defined in two different ways and this posed a problem of consistency. I defined the current year statically using the ‘Configuration’ table.