Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IRMA Module Output Settings and Modify Abricate_flu Module for Specific Flu B Classification #10

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

tives82
Copy link
Collaborator

@tives82 tives82 commented Apr 9, 2024

This pull request introduces two changes that improve the file outputs of the IRMA module and enhance the flu B lineage classification in the Abricate_flu module.

  1. IRMA Module Output Modification: The outputs for BAM and FASTA files have been updated to optional: true. This will ensure that any absence of output BAM and/or FASTA files during IRMA module execution does not cause the process to halt or fail, addressing issues related to missing output files in certain scenarios.

  2. Syntax Update for the Abricate_flu Module: Introduces a better approach to classifying flu B viruses by focusing specifically on the hemagglutinin (HA) and neuraminidase (NA) segments for flu B lineage determination. The revised code now includes a conditional logic to identify the flu B virus as either Victoria or Yamagata lineage based on the presence of HA and NA markers in the abricate output. The updated script checks for the presence of "Type_B" in the classification output and then proceeds to determine the subtype by searching for "Victoria" or "Yamagata" in conjunction with "hemagglutinin" or "neuraminidase". The logic is as follows: if either HA or NA markers, or both, are found in conjunction with "Type B" in the ${meta.id}_abricate_hits.tsv file, the script assigns the respective subtype.
    This modification improves the accuracy of flu B lineage classification by relying on the HA and NA segments, which are the indicators of the flu B lineage, and addresses a previous limitation where lineage assignment might have been inaccurately influenced by non-specific markers such as matrix proteins (MP).

Copy link

github-actions bot commented Apr 9, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 565cbb5

+| ✅  16 tests passed       |+
#| ❔   6 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in meta.yml: #Add a description of all of the variables used as input
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2024-04-09 20:53:05

@erinyoung
Copy link
Member

Is https://github.com/UPHL-BioNGS/walkercreek/blob/master/.devcontainer/devcontainer.json supposed to be a real json file or a pseudo-json file? If it's supposed to be a real json file, there are some extra commas.

Copy link

@jwarnn jwarnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issue with these file changes and test run completed successfully.

@tives82 tives82 merged commit 217de13 into master Apr 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants