Feature/in out folder #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeltevanBoheemen
approved these changes
Jul 3, 2020
| @@ -5,6 +5,11 @@ | |||
| <?=$this->session->flashdata('message'); ?> | |||
| </div> | |||
| <?php } ?> | |||
| <?php if ($this->session->flashdata('error')) { ?> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the parsing to extract everything to an "in" folder and then send the output of corpus2alpino and the merging to an "out" folder. This way archives containing existing xml files can be parsed e.g. a TEI called
tei.xmlwould have a foldertei.xmlin the output, contain1.xml,2.xml, ...n.xmlfor every parsed sentence. This also fixes a whole bunch of other bugs with processing.I've also updated the naming conventions, the example above would get a sentence ID of tei.xml:1 prefixed with the component. Components are titled using slashes (as their directory names).
In the future these changes will also make it feasible to automatically merge chat and pre-annotated lassy files (#18, UUDigitalHumanitieslab/corpus2alpino#7).