Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Migrate to new keyid mappings. #259

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Migrate to new keyid mappings. #259

merged 6 commits into from
Oct 18, 2024

Conversation

kareltucek
Copy link
Contributor

@kareltucek kareltucek commented Sep 20, 2024

When old UserConfig is flashed, the keyboard should still work fine, except that backlight is going to be messed up.

I haven't figured any simple way to translate keyids efficiently on uhk60 that wouldn't require allocation of an additional buffer, so this is going to be a performance drain. As a result, please test that mouse keys still work smoothly with an 8.0.0 config flashed...

Also, not tested. No idea how to test this.

Closes UltimateHackingKeyboard/firmware#935

@mondalaci
Copy link
Member

I guess that we must wait for Agent to test this, right?

Also, am I right that existing UHK 80 configurations will have to be recreated? As for the UHK 60, Agent will translate key ids and update them in the configuration.

Let's not worry about optimization yet.

@kareltucek
Copy link
Contributor Author

I guess that we must wait for Agent to test this, right?

I think so.

Also, am I right that existing UHK 80 configurations will have to be recreated?

Yes, I think it will be the fastest option.

@mondalaci
Copy link
Member

Please resolve conflicts.

@mondalaci
Copy link
Member

What do the following errors mean, and how can they be resolved?

image

I'm testing with UltimateHackingKeyboard/agent80#110 - Feel free to test it and let us know what's missing.

I think Agent doesn't remap UHK 60 keys yet. Should it?

Some of the LEDs are also off:

IMG20241015051912

@mhantsch
Copy link
Contributor

Will macros have to change (on UHK60? On UHK80?) if they refer to keyIds directly?

@kareltucek
Copy link
Contributor Author

Yes. Sorry about that 😞.

@mhantsch
Copy link
Contributor

Yes. Sorry about that 😞.

We need some update docs then. At least in the release notes users need to be alerted about this breaking change.

@kareltucek
Copy link
Contributor Author

(These fix some details on firmware side. There are other major problems though, and they wait for Robi to take a look at them.)

@mondalaci
Copy link
Member

I've just tried this PR with the related Agent PR.

When saving my configuration in Agent, the UHK 60 LEDs got fixed, but the following keys don't send the correct scancode:

  • instead of Mouse, I get a
  • instead of a, I get s
  • instead of s, I get d
  • instead of d, I get f
  • instead of f, I get g
  • instead of g, I get <
  • instead of left shift, I get z
  • instead of z, I get c
  • instead of x, I get v
  • instead of c, I get b
  • instead of v, I get no scancode
  • instead of b, I get LSuper

@kareltucek
Copy link
Contributor Author

Sorry, forgotten about this 🤦.

Except for g, all are left side keys, which makes me wonder if this is a firmware issue instead. Maybe I have forgotten to map reports coming from left half?

@kareltucek
Copy link
Contributor Author

Indeed. Should be working now I hope. Didn't notice any problems on Agent side, but did not do a very deep test.

@mondalaci mondalaci merged commit a82c920 into master Oct 18, 2024
1 check passed
@mondalaci mondalaci deleted the remap_keyids branch October 18, 2024 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New key id scheme
3 participants