-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
297e72f
to
93b79da
Compare
I guess that we must wait for Agent to test this, right? Also, am I right that existing UHK 80 configurations will have to be recreated? As for the UHK 60, Agent will translate key ids and update them in the configuration. Let's not worry about optimization yet. |
93b79da
to
a12734f
Compare
I think so.
Yes, I think it will be the fastest option. |
Please resolve conflicts. |
What do the following errors mean, and how can they be resolved? I'm testing with UltimateHackingKeyboard/agent80#110 - Feel free to test it and let us know what's missing. I think Agent doesn't remap UHK 60 keys yet. Should it? Some of the LEDs are also off: |
Will macros have to change (on UHK60? On UHK80?) if they refer to keyIds directly? |
Yes. Sorry about that 😞. |
We need some update docs then. At least in the release notes users need to be alerted about this breaking change. |
(These fix some details on firmware side. There are other major problems though, and they wait for Robi to take a look at them.) |
I've just tried this PR with the related Agent PR. When saving my configuration in Agent, the UHK 60 LEDs got fixed, but the following keys don't send the correct scancode:
|
Sorry, forgotten about this 🤦. Except for g, all are left side keys, which makes me wonder if this is a firmware issue instead. Maybe I have forgotten to map reports coming from left half? |
Indeed. Should be working now I hope. Didn't notice any problems on Agent side, but did not do a very deep test. |
When old UserConfig is flashed, the keyboard should still work fine, except that backlight is going to be messed up.
I haven't figured any simple way to translate keyids efficiently on uhk60 that wouldn't require allocation of an additional buffer, so this is going to be a performance drain. As a result, please test that mouse keys still work smoothly with an 8.0.0 config flashed...
Also, not tested. No idea how to test this.
Closes UltimateHackingKeyboard/firmware#935