-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Build aarch64 linux and simplify matrix #334
Conversation
... if the optional changes above are desired, I'll open a separate PR first to just make |
macos-13 is being deprecated, no? I believe that cross-compiling will be the only option moving forward. |
At least from actions/runner-images#9255 (comment) I don't see it deprecated: Maybe you're thinking of macos-11 which is indeed deprecated? I have to imagine The current docs of |
Maybe is was Azure. Too many CIs to manage. |
ubuntu-22.04 aarch64 wheel build test is failing with
|
Okay I think this one should be good to go. Comments are in the YAML, but the short version in that I now have the wheel building run in PRs but for PRs cut down on which ones get built for speed. For Ubuntu, macOS, and Windows, the longest is 4m (Windows). The new |
@larsoner this looks great, thank you. Can you add an item to the Changelog before I merge? |
Done! |
Thanks! |
This has some opinionated optional changes, let me know if they're worth keeping:
include:
the desired ones explicitly. It seems more readable in the end to me at least!master
. Assuming it's fast enough, might as well if it's quick (but can be reverted if it's not!) since it tests a bunch of archs/oses.macos-14
so should be fast enough hopefully?And it also includes the change that I actually set out to implement, namely adding Linux
aarch64
wheels.Closes #333