Add pyproject fmt #1267
Open
Add pyproject fmt #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, it broke what it was supposed to fix, the pyproject.toml! I'll try to figure out what is happening... |
ocefpaf
force-pushed
the
add_pyproject-fmt
branch
2 times, most recently
from
792546b to
1872af6
Compare
|
Found the problem and it may be a bug in the linter. xref.: tox-dev/pyproject-fmt#110 |
|
There is an opendap sever failure now that is unrelated. |
ocefpaf
force-pushed
the
add_pyproject-fmt
branch
from
2bea66b to
a805435
Compare
|
This one is ready for review. |
|
I've been increasing my use of pre-commit (+ .ci) lately, but I've not heard of pyproject-fmt until now. I'm unsure about it's inconsistency, however. For example, some sections have a 1-line space between and others don't, some have sorted keys, others don't. Some local tests that I tried with this branch, where I've re-arranged some items in the pyproject file will yield bad formats too, so I can't grasp what the tool is trying to do. |
ocefpaf
force-pushed
the
add_pyproject-fmt
branch
from
a805435 to
4aaacf5
Compare
ocefpaf
force-pushed
the
add_pyproject-fmt
branch
2 times, most recently
from
ed9b78b to
cc67592
Compare
ocefpaf
force-pushed
the
add_pyproject-fmt
branch
from
bba00d9 to
8cae84c
Compare
ocefpaf
force-pushed
the
add_pyproject-fmt
branch
2 times, most recently
from
1d30b5e to
85a76e9
Compare
ocefpaf
force-pushed
the
add_pyproject-fmt
branch
from
85a76e9 to
9aa0af0
Compare
ocefpaf
force-pushed
the
add_pyproject-fmt
branch
from
29db584 to
cbd485d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent a regression in #1265 and complements @mwtoews #1266.
Note that the use of pre-commits has a learning curve and while I would advocate to a even heavier use than just this one, I'm OK if this PR is closed in case folks don't want to go there. However, if you do, one can set it up locally and run
pre-commitor use the pre-commit hook. Additionally one can enable pre-commit-ci and use thepre-commit.ci autofixcomment in the PR to fix it automatically. Enabling pre-commit-ci has the advantages of having this as a CI check and get the auto-updates for the hooks in the .pre-commit.yaml file.