chore: include missing netcdf headers in manifest / sdist #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jswhit
added a commit
that referenced
this pull request
Jun 14, 2024
|
this should be fixed by using setuptools_scm (part of PR #1337) |
|
Yeah, looks like we have duplicated some work here. Given how small the scope of this change is relative to #1337 I will keep this open and let the maintainers decide what direction to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include missing
netcdfheaders during packaging (i.e. in ansdist). These are opened insetup.pyin certain build configurations if building from a source distribution.related #1329