Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Zora Support #501

Closed
wants to merge 1 commit into from
Closed

[feat] Zora Support #501

wants to merge 1 commit into from

Conversation

tbtstl
Copy link

@tbtstl tbtstl commented Feb 22, 2024

This PR adds support for the Uniswap Deployment on Zora Network.

This PR is currently blocked by sdk-core#121

@tbtstl tbtstl requested a review from a team as a code owner February 22, 2024 16:38
Copy link
Member

@jsy1218 jsy1218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a guide for adding new chain in SOR https://github.com/Uniswap/smart-order-router?tab=readme-ov-file#adding-a-new-chain.

Feel free to take a look at how I added OP Sepolia support #486

@jsy1218
Copy link
Member

jsy1218 commented Feb 27, 2024

Also sdk-core new version needs to be published to npmjs repo, and add into this PR as well. I can help with publishing new sdk-core version, since the publish perm is limited to a subset of uniswap labs employee.s

Copy link

stale bot commented Apr 27, 2024

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Apr 27, 2024
@stale stale bot closed this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants