Pashov L-05 add more special characters to escape #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
reviewed
Oct 24, 2024
| @@ -503,6 +503,10 @@ library Descriptor { | |||
| } | |||
| } | |||
|
|
|||
| function isSpecialCharacter(bytes1 b) private pure returns (bool) { | |||
| return b == '"' || b == "\u000c" || b == "\n" || b == "\r" || b == "\t"; | |||
There was a problem hiding this comment.
am i mad? surely \u000c is longer than a single byte?
There was a problem hiding this comment.
I had exactly the same thought! Turns out it gets properly escaped to 1 byte:
pragma solidity ^0.8.0;
contract RandomTest {
function stringToBytes32() public pure returns (uint256 length) {
string memory source = "\u000c";
bytes memory tempEmptyStringTest = bytes(source);
return tempEmptyStringTest.length;
}
}
If you test this out in Remix the return value is 1 :)
There was a problem hiding this comment.
wild, thanks for the poc :)
hensha256
previously approved these changes
Oct 24, 2024
hensha256
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Pashov L-05 https://github.com/PashovAuditGroup/Uniswap_October_MERGED/issues/9
Special characters not escaped can produce invalid JSON
Description of changes
check form feeds, new lines, carriage returns, or tabs to escape