Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-0000: CameraDeactivated events were not sent when a blend interrupted another #1028

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Nov 21, 2024

Purpose of this PR

Bug reported on forum: https://discussions.unity.com/t/when-new-blend-occurs-first-blends-deactivated-event-is-muted/1556716

Camera deactivated events were never being sent for camera A in the situation of blending (A ->B) -> C.
We would expect to get a deactivation for A at the end of (A -> B).

Added unit test for this case.

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.09%. Comparing base (ba4cc2b) to head (78e7097).
Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
...machine/Runtime/Helpers/CinemachineCameraEvents.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
+ Coverage   26.97%   27.09%   +0.12%     
==========================================
  Files         254      254              
  Lines       28418    28452      +34     
==========================================
+ Hits         7665     7710      +45     
+ Misses      20753    20742      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jmcduff-unity jmcduff-unity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@glabute glabute merged commit 6c06201 into main Dec 11, 2024
3 of 69 checks passed
@glabute glabute deleted the dev/bugfix-for-camera-deactivated-event branch December 11, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants