Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added service to enable and disable tool contact. #686

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

URJala
Copy link
Collaborator

@URJala URJala commented Feb 22, 2024

Also added service to get robot software version.

This PR requires the changes from PR.

This adds support for tool contact as proposed in #678.

@urrsk urrsk requested a review from fmauch April 4, 2024 12:19
@urrsk
Copy link
Member

urrsk commented Apr 4, 2024

@fmauch the dependency for getting the version is due to test if we expect a "fail" from the client lib or not.
An alternative, and maybe better, could be to pass down the robot version from the test launch file so it already knows that version of robots it is testing on. Though it also seems that we only are testing on a UR5e!

@URJala
Copy link
Collaborator Author

URJala commented Apr 11, 2024

I have split this PR in to two seperate PRs. This one now only contains the tool contact functionality. The get version functionality has been moved to PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants