Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chunking_strategy kwarg #238

Merged
merged 17 commits into from
Sep 21, 2023
Merged

feat: add chunking_strategy kwarg #238

merged 17 commits into from
Sep 21, 2023

Conversation

Coniferish
Copy link
Collaborator

@Coniferish Coniferish commented Sep 18, 2023

Add chunking_strategy as a kwarg for parsing and associated test.

Testing

curl -X 'POST' 'http://127.0.0.1:8000/general/v0/general' \
 -H 'accept: application/json'  \
 -H 'Content-Type: multipart/form-data' \
 -F 'files=@sample-docs/layout-parser-paper-fast.pdf' \
 -F 'chunking_strategy=by_title' \
 | jq -C . | less -R

@Coniferish Coniferish changed the title first pass at adding chunking_strategy feat: add chunking_strategy kwarg Sep 19, 2023
@Coniferish Coniferish marked this pull request as ready for review September 19, 2023 22:13
@cragwolfe cragwolfe requested a review from awalker4 September 19, 2023 22:23
Copy link
Collaborator

@awalker4 awalker4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you start a new version in the CHANGELOG? You'll need to run make version-sync once that's updated.

README.md Show resolved Hide resolved
@Coniferish Coniferish requested a review from awalker4 September 21, 2023 16:08
Copy link
Collaborator

@awalker4 awalker4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Coniferish Coniferish merged commit 49fe710 into main Sep 21, 2023
6 checks passed
@Coniferish Coniferish deleted the jj/231-chunking branch September 21, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants