feat/vectara-destination-to-v2 #158
Conversation
bryan-unstructured
added
ready for review
| customer_id="2268229652", | ||
| corpus_name=f"test-corpus-vectara-{random.randint(1000,9999)}", | ||
| corpus_id="3232", | ||
| token_url="https://vectara-prod-{}.auth.us-west-2.amazoncognito.com/oauth2/token", |
There was a problem hiding this comment.
General question, does this example run out of the box (as is), or should user eg. create new Vectara cluster and replace here some vars like corpus_id or customer_id?
There was a problem hiding this comment.
From my past impression, connectors are not supposed to create cluster/db/index if they don't exist. So this example won't work out of the box. User needs to create corpora first, then replace the ids here.
There was a problem hiding this comment.
Ok, then adding a short comment about it would be good/helpful for the users, who won't need to look into code of connector to know that it has to be done. Or run it without creating, and getting confused by errors. Other connectors don't have such comments, but we could start by increasing the standard here.
bryan-unstructured
temporarily deployed
to
ci
GitHub Actions
Inactive
bryan-unstructured
temporarily deployed
to
ci
GitHub Actions
Inactive
bryan-unstructured
temporarily deployed
to
ci
GitHub Actions
Inactive
bryan-unstructured
temporarily deployed
to
ci
GitHub Actions
Inactive
bryan-unstructured
temporarily deployed
to
ci
GitHub Actions
Inactive
bryan-unstructured
temporarily deployed
to
ci
GitHub Actions
Inactive
bryan-unstructured
temporarily deployed
to
ci
GitHub Actions
Inactive
bryan-unstructured
temporarily deployed
to
ci
GitHub Actions
Inactive
No description provided.