feat/improve file data batch content #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrahey
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Deferring comments on the actual changes for a sec - the sheer proportion of the diff dedicated to innocuous changes to test fixtures is really striking me this time around. Have we explored pulling the artifacts (and perhaps even the scenarios themselves) into a different system? Manage them like artifacts - out of band from the code?
|
My next comment, again not truly a code level conversation yet, but closer: How do you feel about collapsing the case of single and batch into a world where everything is a batch, and it just so happens that sometimes that batch is of size 1? |
rbiseck3
force-pushed
the
roman/batch-id-file-data
branch
from
3a0eda3 to
e0e6dd1
Compare
rbiseck3
force-pushed
the
roman/batch-id-file-data
branch
from
c2646a0 to
ba84286
Compare
vangheem
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert the
FileDataclass to be a pydantic model to have better field validation on it. Also create inheritedFileDataclasses for batch support and inter-index-downloader communication.