feat/drop unstructured constraint #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbiseck3
changed the title
|
|
||
| @pytest.mark.parametrize("chunker_file", chunker_files, ids=[path.name for path in chunker_files]) | ||
| @pytest.mark.parametrize("strategy", ["basic", "by_title"]) | ||
| def test_chunker_basic(chunker_file: Path, strategy: str): |
There was a problem hiding this comment.
any way this can be recreated in the original Unstructured repo or somewhere, if it's being pesky here due to nltk? It's always hard to give up tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently the unstructured dependency changed how NLTK data was being downloaded. This dependency is not a hard requirement for this repo and so the constaint on that dependency was lifted to be able to pull in the latest, but the use of it was isolated to only the unit test CI job to prevent collisions with underlying dependencies that are needed elsewhere, rather than have it as a shared dependency with everything else using pytest.