Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds How to document with associated images #434

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Adds How to document with associated images #434

merged 5 commits into from
Jan 22, 2024

Conversation

asthad1
Copy link
Collaborator

@asthad1 asthad1 commented Oct 21, 2023

Adds How to document with associated images

What does this Pull Request do? (:star:)

This adds how to document with its associated image.

What's the changes? (:star:)

No changes to existing flow.

How should this be tested?

A description of what steps someone could take to:

  • Make sure the links can be accessed.
  • Make sure the images attached can be accessed.

Interested parties

@goynejennifer

@asthad1 asthad1 requested a review from whunter October 21, 2023 17:58
@asthad1 asthad1 requested a review from goynejennifer November 6, 2023 20:34
Copy link
Collaborator

@goynejennifer goynejennifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update this document with a good example of an identifier and how to fill in the rest of the data. Let me get additional data from Lee to send to you

@goynejennifer goynejennifer self-assigned this Nov 15, 2023
@goynejennifer
Copy link
Collaborator

Going forward all identifiers for collections should be prepended with the "collection_category." (lowercase) and then an underscore. For example if collection category going to South West Virginia Archive "swva." All identifiers for archives (items) should be prepended with the "collection_category" and the identifier of the collection to which it belongs, with the three values separated by an underscore and everything lowercase. So for this collection it's just swva_fchs_. For example an item in this collection will be swva_fchs_1950.001.001 and then the number could be used in a category other identifier 1950.001. If you can include this information in the identifer section that would do it

@goynejennifer goynejennifer removed their assignment Nov 15, 2023
@goynejennifer goynejennifer self-requested a review November 15, 2023 20:44
Copy link
Collaborator

@goynejennifer goynejennifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for making the change.

@asthad1 asthad1 merged commit 6978a7e into dev Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants