Updating a style to be applied to the federated site. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLG 12012023
asthad1
reviewed
Dec 6, 2023
There was a problem hiding this comment.
@goynejennifer is there a specific reason why this is set to null?
There was a problem hiding this comment.
Not sure why this is set to Null did I set this to null. I probably should be set to a value.
There was a problem hiding this comment.
It came from your merge request. So I guess its you.
There was a problem hiding this comment.
LOL. As far as I know it's just extra files the Visual Studio creates but maybe I don't need to check in just to keep locally.
asthad1
reviewed
Dec 6, 2023
There was a problem hiding this comment.
@goynejennifer I am not sure if this is required for the project. I see your local path so not sure how this is used?
JLG 12212023
|
Preview branch generated at https://JLG-DevUpdateFederatedStyles.d234tdmg9icdwk.amplifyapp.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JLG 12012023
Updating Style in FeatureItems.scss to get the circles in the federated to work properly
JIRA Ticket: (link) (:star:)
What does this Pull Request do? (:star:)
This pull request should fix the issue with the 3 circles that are on the federated preproduction site.
What's the changes? (:star:)
The FeatureItems.scss line 19 was commented out to get the three circles on the federated site working.
Example:
Updated FeatureItems.scss, line 19, commented out the height because it was messing up the circles.
How should this be tested?
To test this out push the updated .scss style file to the preproduction federated website to test if the change does work on the federated website. https://federated-pprd.dlp.cloud.lib.vt.edu/
A description of what steps someone could take to:
None
Additional Notes:
Any additional information that you think would be helpful when reviewing this PR.
Example:
This was branched off the main dev branch.
Interested parties
Tag (@ mention) interested parties
(:star:) Required fields