Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress 13 migration #438

Merged
merged 1 commit into from
Jan 31, 2024
Merged

cypress 13 migration #438

merged 1 commit into from
Jan 31, 2024

Conversation

otokama
Copy link
Member

@otokama otokama commented Jan 25, 2024

Migration to Cypress v13.6.2


Asana Ticket: (link) (:star:)
https://app.asana.com/0/1205959349035436/1206174640295324/f

What does this Pull Request do? (:star:)

Upgrade current Cypress version to v13.6.2

What's the changes? (:star:)

  • Upgraded Cypress version to v13.6.2
  • Made necessary changes to ensure all tests still run and pass in Cypress v13
  • Added back site admin tests

How should this be tested?

All tests should pass after the migration, including the site admin tests.

Interested parties

@whunter @goynejennifer

(:star:) Required fields

Copy link

Preview branch generated at https://cy-version-upgrade.d234tdmg9icdwk.amplifyapp.com

@otokama otokama force-pushed the cy-version-upgrade branch from bf21aee to 1683543 Compare January 25, 2024 20:45
Copy link
Member

@whunter whunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks for your work on this. It's really going to help get our stack back to a more reliable and more current state.

https://github.com/VTUL/dlp-access/pull/438/files#diff-a3d2ece2d765cca25219566fd78f2b8cb5b054d1bd940c945ff2a2669085bd79R80

At some point in the future we should add an id or a class to whatever element ".contains('X')" in that test so that we can just use a selector on THAT element instead of doing all of those parent() calls, which make the test more fragile. There's probably a lot of occurrences like this. We also need to add ids/classes to a bunch of elements that have siblings. That way we can also remove a bunch of ":nth-child" selectors which also make tests more fragile for similar reasons.

Thanks again! This is awesome.

@whunter whunter merged commit 928357c into dev Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants