Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated root.css card and update FeatureItems.scss line 60 added a vi… #454

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

goynejennifer
Copy link
Collaborator

This Pull Request is to fix the button and grey boxes around the federated website.


What does this Pull Request do? (:star:)

The updated root.css and FeatureItems.scss line 60 added a visibility tag and changed the visibility to hidden

What's the changes? (:star:)

The only changes are style related in the root.css and FeatureItem.scss

Example:

  • Changes to the root.css line 5099 commented out the border of the button on the page
  • Changes to the FeatureItem.scss line 60 added a visibility tag with a default to hidden;

How should this be tested?

A description of what steps someone could take to:

  • To test this out what I would do is open the page and your shouldn't see the button at the bottom and grey boxes should be removed.

Additional Notes:

No other additional information is needed when reviewing this PR.

Interested parties

Tag (@ mention) interested parties

(:star:) Required fields

@goynejennifer goynejennifer requested a review from whunter March 25, 2024 20:37
@goynejennifer goynejennifer self-assigned this Mar 25, 2024
Copy link
Member

@whunter whunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes look great. I added a second commit with one suggestion. It removes the little grey borders from the featured item cards. Do you think that would be ok? I bet Bill would approve. It simplifies the layout a little bit. It would look like this:
Screenshot 2024-04-02 at 9 53 00 AM

@whunter whunter merged commit 9fdfb56 into dev Apr 2, 2024
@whunter whunter deleted the federatedstyleissue branch April 2, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants