Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes several bugs related to "Additional Pages" functionality. Menu, rendering, etc #459

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

whunter
Copy link
Member

@whunter whunter commented Apr 22, 2024

About Our Collections text removed, hamburger fixed, additional pages links fixed, allow scripts in additional pages conditionally.


What's the changes? (:star:)

A in-depth description of the changes made by this PR. Technical details and possible side effects.

  • About Our Collections removed
  • hamburger icon fixed to disappear when horizontal menu appears
  • Additional pages links fixed (content was not changing on menu click)
  • allow scripts in additional pages under extremely limited circumstances

How should this be tested?

  • preview is here: https://bug-fixes.d234tdmg9icdwk.amplifyapp.com/
  • Check that the /collections page no longer renders "About Our Collections" in the "hero" section.
  • Check that the hamburger menu icon disappears at the same width that the horizontal menu appears
  • Check that the page content changes when clicking back and forth between the "Additional Pages" menu links
  • Check that the map renders correctly on the "Maps" page and that it doesn't break the page when clicking away from Maps and then back to it.

Additional Notes:

  • branch: bug_fixes

Interested parties

@goynejennifer

(:star:) Required fields

…s fixed, allow scripts in additional pages conditionally
@goynejennifer
Copy link
Collaborator

I tested this and it works as expected. Nice Job

@whunter whunter merged commit 355658b into dev Apr 22, 2024
0 of 2 checks passed
@whunter whunter deleted the bug_fixes branch April 22, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants