Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render git commit info if env var is set #462

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

whunter
Copy link
Member

@whunter whunter commented May 2, 2024

render git commit info above footer if env var is set


JIRA Ticket: (link) (:star:)

  • Other Relevant Links (Meeting note, project page, related pull requests, etc.)

What does this Pull Request do? (:star:)

renders git commit info above footer if env var is set

How should this be tested?

  • visit generated preview site
  • check that commit number is rendered above footer in a usable link to that commit. It should be the first 7 characters of this commit: 13942cd

Additional Notes:

  • branch: git_commit_section

Interested parties

@goynejennifer

(:star:) Required fields

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-462.d234tdmg9icdwk.amplifyapp.com

@whunter whunter force-pushed the git_commit_section branch from 13942cd to 2004de5 Compare May 3, 2024 19:15
Copy link
Collaborator

@goynejennifer goynejennifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, variable shows up in the footer.

took out h1

logging

don't substring if <= 8???
@whunter whunter force-pushed the git_commit_section branch from 2004de5 to 735d6f4 Compare May 6, 2024 15:28
@whunter whunter merged commit b8c6643 into dev May 7, 2024
1 check failed
@whunter whunter deleted the git_commit_section branch May 7, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants