Add 3D/2D view #465
Merged
Add 3D/2D view #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whunter
requested review from
goynejennifer and
otokama
and removed request for
goynejennifer and
otokama
mostly working? add map w/ styles comment-- toggle visibility. load 3d larger fix mirador it's reloading for now. It's fine controls resizing to fit. yay still working on scaling move leaflet css tests and pdfs and such
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
goynejennifer
requested review from
asthad1
and removed request for
goynejennifer
|
Style change: Can we make the 3D view the entire window 1016px by 720px will cover the whole window |
|
The other thing when we click full screen and it appears on full screen the image is kinda grayed out. Also I can no longer use my mouse trackpad to zoom in or zoom out. We have to use the zoom in/out button. |
asthad1
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds view to render x3dom model and mirador viewer in same display and allow toggling between them.
JIRA Ticket: (link) (:star:)
What does this Pull Request do? (:star:)
Adds view to render x3dom model and mirador viewer in same display and allow toggling between them.
What's the changes? (:star:)
How should this be tested?
Already imported 3D/2D records include:
VTEC000004835
VTEC000004836
VTEC000004837
VTEC000004838
VTEC000004841
VTEC000004842
VTEC000004843
VTEC000004844
VTEC000004845
VTEC000004847
VTEC000004848
VTEC000004849
VTEC000004850
VTEC000004851
VTEC000004853
VTEC000004854
Additional Notes:
3d_view_refactorInterested parties
@goynejennifer @otokama
(:star:) Required fields