Add additional JSON schema validation for registered settings.

Vector35 · May 27, 2024 · 309d606 · 309d606
1 parent 7146494
commit 309d606
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/binaryninjaapi.h b/binaryninjaapi.h
@@ -15840,7 +15840,7 @@ namespace BinaryNinja {
 			"message"            string                                   None                 Yes        An optional message with additional emphasis
 			"readOnly"           bool                                     None                 Yes        Only enforced by UI elements
 			"optional"           bool                                     None                 Yes        Indicates setting can be null
-			"hidden"             bool                                     "type" is "string"   Yes        Indicates the UI should conceal the content
+			"hidden"             bool                                     "type" is "string"   Yes        Indicates the UI should conceal the content. The "ignore" property is required to specify the applicable storage scopes
 			"requiresRestart     bool                                     None                 Yes        Enable restart notification in the UI upon change
 			"uiSelectionAction"  string                                   "type" is "string"   Yes        {"file", "directory", <Registered UIAction Name>} Informs the UI to add a button to open a selection dialog or run a registered UIAction
 			==================   ======================================   ==================   ========   =======================================================================

diff --git a/python/settings.py b/python/settings.py
@@ -77,7 +77,7 @@ class Settings:
 		"message"             string                                   None                 Yes        An optional message with additional emphasis
 		"readOnly"            boolean                                  None                 Yes        Only enforced by UI elements
 		"optional"            boolean                                  None                 Yes        Indicates setting can be null
-		"hidden"              bool                                     "type" is "string"   Yes        Indicates the UI should conceal the content
+		"hidden"              bool                                     "type" is "string"   Yes        Indicates the UI should conceal the content. The "ignore" property is required to specify the applicable storage scopes
 		"requiresRestart      boolean                                  None                 Yes        Enable restart notification in the UI upon change
 		"uiSelectionAction"   string                                   "type" is "string"   Yes        {"file", "directory", <Registered UIAction Name>} Informs the UI to add a button to open a selection dialog or run a registered UIAction
 		===================   ======================================   ==================   ========   =======================================================================