Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix metadata impl From lists #5276

Merged
merged 2 commits into from
May 1, 2024
Merged

fix metadata impl From lists #5276

merged 2 commits into from
May 1, 2024

Conversation

rbran
Copy link
Contributor

@rbran rbran commented Apr 14, 2024 •
edited
Loading

TODO:

  • Stack overflow

The code let _metadata: Ref<Metadata> = (&Ref::<Metadata>::from(false)).into(); result in stack overflow caused by the impl<T: Into<Ref<Metadata>>> From<&T> for Ref<Metadata>

@rbran rbran marked this pull request as ready for review April 14, 2024 14:46
@rbran rbran mentioned this pull request Apr 15, 2024
Closed
@plafosse plafosse requested a review from ElykDeer April 17, 2024 17:30
@rssor rssor merged commit 2fb7daa into Vector35:dev May 1, 2024
2 checks passed
@rbran rbran deleted the fix-metadata-from branch May 1, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElykDeer ElykDeer Awaiting requested review from ElykDeer

Assignees

@rssor rssor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbran @rssor