Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only create FlowGraph with Ref #5307

Merged
merged 1 commit into from
May 9, 2024
Merged

only create FlowGraph with Ref #5307

merged 1 commit into from
May 9, 2024

Conversation

rbran
Copy link
Contributor

@rbran rbran commented Apr 22, 2024

No description provided.

@rbran
Copy link
Contributor Author

rbran commented Apr 22, 2024

It's unclear no me if BNShowGraphReport require a owned FlowGraph object or only a reference to it. I assumed only a reference, because the method BinaryViewExt::show_graph_report received a FlowGraph parameter and not a Ref<FlowGraph>

@rbran rbran marked this pull request as ready for review May 6, 2024 13:27
@ElykDeer ElykDeer merged commit 4e2fbc2 into Vector35:dev May 9, 2024
2 checks passed
@rbran rbran deleted the flowgraph-ref branch May 9, 2024 16:44
@ElykDeer ElykDeer self-assigned this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElykDeer ElykDeer ElykDeer approved these changes

Assignees

@ElykDeer ElykDeer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbran @ElykDeer