Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): voiceMuteBlockedUsers #3001

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

Vexify4103
Copy link

@Vexify4103 Vexify4103 commented Nov 6, 2024

Basically as the title describes.
Normal block just restrains certain users from messaging you etc. -> This also voicemutes them.
Option to do this automatic or with button.

Before:
{B45BE077-A6FD-4047-A760-6EA64773C93E}

After:
{E1AA51A6-CD2C-4DFF-A420-AC221CF47733}

Basically as the title describes.
Normal block just restrains certain users from messaging you etc.
This also voicemutes them.
Option to do this automatic or with button.
Copy link
Contributor

@schoeneBiene schoeneBiene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were parts of this written with ai? this has a lot of unnecessary comments

src/plugins/voiceMuteBlockedUsers/index.tsx Outdated Show resolved Hide resolved
src/plugins/voiceMuteBlockedUsers/index.tsx Outdated Show resolved Hide resolved
src/plugins/voiceMuteBlockedUsers/index.tsx Outdated Show resolved Hide resolved
src/plugins/voiceMuteBlockedUsers/index.tsx Show resolved Hide resolved
@Vexify4103
Copy link
Author

were parts of this written with ai? this has a lot of unnecessary comments

Haha yes I was trying some ai comments on js docs 💀

Vexify4103 and others added 6 commits November 7, 2024 18:39
Co-authored-by: goodbee <100511746+schoeneBiene@users.noreply.github.com>
Co-authored-by: goodbee <100511746+schoeneBiene@users.noreply.github.com>
- added README.md file
- made sure to not unmute not blocked users
- removed unnecessary comments
@ahoyarou
Copy link

  1. I think the button in the context menu is useless
  2. What are the lags when enabling the plugin and blocking users?

Uploaded images to the image thread and linked them.
@Vexify4103
Copy link
Author

  1. I think the button in the context menu is useless
  2. What are the lags when enabling the plugin and blocking users?

Lags? What Lags?
Can you tell me what to do to reproduce that?
And The button in what context menu?
Like I like the insta one to "block and mute" because that also skips the extra step of "are you sure you want to block personXY?"

@ahoyarou
Copy link

ahoyarou commented Nov 18, 2024

  1. I think the button in the context menu is useless
  2. What are the lags when enabling the plugin and blocking users?

Lags? What Lags? Can you tell me what to do to reproduce that? And The button in what context menu? Like I like the insta one to "block and mute" because that also skips the extra step of "are you sure you want to block personXY?"

When I block someone using this plugin, it takes half a second before I can browse channels or do anything else
Also, I realize that if many people are muted, Discord has a limit and some of that list is deleted (I mean the muted ones), including those I blocked using this plugin

@Vexify4103
Copy link
Author

Vexify4103 commented Nov 24, 2024

  1. I think the button in the context menu is useless
  2. What are the lags when enabling the plugin and blocking users?

Lags? What Lags? Can you tell me what to do to reproduce that? And The button in what context menu? Like I like the insta one to "block and mute" because that also skips the extra step of "are you sure you want to block personXY?"

When I block someone using this plugin, it takes half a second before I can browse channels or do anything else Also, I realize that if many people are muted, Discord has a limit and some of that list is deleted (I mean the muted ones), including those I blocked using this plugin

How many users do you have blocked / muted in general?
I have 100+ Blocked and I have no issues what so ever with my plugin..

Searching the web I also found an insane high number for blocked people "22,549" and then another one for "5000" and I doubt you have reached any of those.

Vexify4103 and others added 7 commits November 24, 2024 13:55
Description:
Refactored the automaticMuteBlockedUsers function to enhance performance and reduce resource usage.
Implemented batch processing for muting blocked users, allowing multiple users to be muted in a single operation.
Utilized a Set for storing blocked user IDs, improving lookup efficiency when checking if a user is blocked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants