Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/vminsert: excluded vmrange and le labels from sharding #6442

Closed

Conversation

AndrewChubatiuk
Copy link
Contributor

Describe Your Changes

to get proper results on operations over histograms, excluded le and vmrange labels from shard index calculation
related to #6424

Checklist

The following checks are mandatory:

Copy link
Contributor

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hagen1778 hagen1778 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
However, it misses comment explaining why these labels are excluded from sharding. And a changelog describing what was done, with what purpose and what user should expect.

@AndrewChubatiuk AndrewChubatiuk force-pushed the exclude-le-vmrange-labels-from-sharding branch from 2aab7ec to 39542f0 Compare June 11, 2024 08:47
@AndrewChubatiuk
Copy link
Contributor Author

AndrewChubatiuk commented Jun 11, 2024

@hagen1778 updated changelog and added comment

@AndrewChubatiuk AndrewChubatiuk force-pushed the exclude-le-vmrange-labels-from-sharding branch from 05eedf1 to f993313 Compare June 11, 2024 10:33
@AndrewChubatiuk AndrewChubatiuk force-pushed the exclude-le-vmrange-labels-from-sharding branch from f993313 to b9027fb Compare June 11, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants