[wrong target branch] #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements
sahithyandev
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| export default async function (req: Request, res: Response) { | ||
| const userError = (message: string) => { | ||
| res.status(400).send(message); |
Check warning
Code scanning / CodeQL
Information exposure through a stack trace Medium
| event, | ||
| }; | ||
|
|
||
| window.postMessage(message, "*"); |
Check warning
Code scanning / CodeQL
Cross-window communication with unrestricted target origin Medium
| mixpanel.track(eventName, { ...others, distinct_id: userId }); | ||
| } | ||
|
|
||
| res.status(200).send(userId); |
Check warning
Code scanning / CodeQL
Reflected cross-site scripting Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the user id was passed as a cookie. Due to some security limitations, it wasn't included in subsequent calls. And I couldn't find a quick workaround for it.
I refactored the code to
(
sendEventfunction takes care of these).