Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to black font in TOML theme, fix CI #183

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Conversation

Vindaar
Copy link
Owner

@Vindaar Vindaar commented Sep 5, 2024

The CI was broken, due to the bug fix for issue #180.

When using tomlTheme to customize a plot at runtime on non Cairo backends the font was invisible if no color was given.

I developed the code only using the TikZ backend, where black is the
default color. On Cairo this is required to get any visible font!
The facet plot changed due to

SciNim/Datamancer#68

Previously it was missing some data.
To make sure we have the fixed `arrange` behavior
@Vindaar Vindaar merged commit fbe3b39 into master Sep 5, 2024
12 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant