-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A sizeable plugin update #24
Conversation
… decompilation support
… decompilation support
…-and-kotlin # Conflicts: # build.gradle.kts
Can you explain what was causing the race condition so I can understand your changes? |
I'm not fully confident on what caused the race condition exactly, but my best guess is that the read action to load a classfile was waiting on the main thread, itself waiting on the read action before passing control back to the decompiler. By using the queue system already present for cases in which read access was allowed, it seems to fix the deadlock. The change to always using the queue was a hopeful guess that seems to work from my testing. |
After a handful of messing around, I've succeeded in some key goals, and I think it's enough to improve the plugin enough