This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Python 3 compatibility #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Work is heavily dependent on string/binary/unicode so installed and used six - Unittests work in both python 2.7 and 3.7 - Tests needed to be butchered because we're expecting wsgi to return strings(unicode) when in fact, it deals with bytes so comparison can't be made between versions correctly
LilyFoote
approved these changes
Oct 1, 2019
| self.failUnless(response.ok) | ||
| self.assertEqual('@©', page.request(1).body) |
There was a problem hiding this comment.
Could we do something like this?
self.assertEqual('@©'.encode('utf-8'), page.request(1).body)| with self.server: | ||
| response = self.post('page', 'sample data string in request') | ||
| self.failUnless(response.ok) | ||
| self.assertEqual('sample data string in request', page.request(1).body) | ||
| self.assertEqual('@©', page.content) |
There was a problem hiding this comment.
You've also removed this assert. Can we use encode here instead?
| @@ -23,35 +24,33 @@ def test_get_page(self): | |||
| with self.server: | |||
| response = self.get('page') | |||
| self.failUnless(response.ok) | |||
There was a problem hiding this comment.
failUnless is a deprecated alias for assertTrue (https://docs.python.org/2/library/unittest.html#deprecated-aliases).
Suggested change
| self.failUnless(response.ok) | |
| self.assertTrue(response.ok) |
|
Circle didn't run this because it's on a fork. I've enabled running for forks for this repo - could you see if you can re-push the branch? Not quite sure what would trigger a build. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used six
strings(unicode) when in fact, it deals with bytes so comparison can't
be made between versions correctly