fix: slice replace cloneDeep consider about performance

VisActor · Aug 24, 2023 · 25cbde4 · 25cbde4
1 parent 76bbf31
commit 25cbde4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/packages/vscale/src/log-scale.ts b/packages/vscale/src/log-scale.ts
@@ -3,7 +3,6 @@ import { ContinuousScale } from './continuous-scale';
 import { ScaleEnum } from './type';
 import { logp, nice, powp, logNegative, expNegative, identity } from './utils/utils';
 import type { ContinuousScaleType, NiceOptions, NiceType } from './interface';
-import { cloneDeep } from '@visactor/vutils';
 
 /**
  * 逆反函数
@@ -211,7 +210,7 @@ export class LogScale extends ContinuousScale {
   niceMin(): this {
     const maxD = this._domain[this._domain.length - 1];
     this.nice();
-    const niceDomain = cloneDeep(this._domain);
+    const niceDomain = this._domain.slice();
 
     if (this._domain) {
       niceDomain[niceDomain.length - 1] = maxD;
@@ -229,7 +228,7 @@ export class LogScale extends ContinuousScale {
   niceMax(): this {
     const minD = this._domain[0];
     this.nice();
-    const niceDomain = cloneDeep(this._domain);
+    const niceDomain = this._domain.slice();
 
     if (this._domain) {
       niceDomain[0] = minD;

diff --git a/packages/vscale/src/symlog-scale.ts b/packages/vscale/src/symlog-scale.ts
@@ -1,4 +1,3 @@
-import { cloneDeep } from '@visactor/vutils';
 import type { ContinuousScaleType, NiceOptions, NiceType } from './interface';
 import { LinearScale } from './linear-scale';
 import { ScaleEnum } from './type';
@@ -111,7 +110,7 @@ export class SymlogScale extends LinearScale {
   niceMin(): this {
     const maxD = this._domain[this._domain.length - 1];
     this.nice();
-    const niceDomain = cloneDeep(this._domain);
+    const niceDomain = this._domain.slice();
 
     if (this._domain) {
       niceDomain[niceDomain.length - 1] = maxD;
@@ -129,7 +128,7 @@ export class SymlogScale extends LinearScale {
   niceMax(): this {
     const minD = this._domain[0];
     this.nice();
-    const niceDomain = cloneDeep(this._domain);
+    const niceDomain = this._domain.slice();
 
     if (this._domain) {
       niceDomain[0] = minD;