-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API spec in explainer to match latest discussion #16
Conversation
- Fix WICG#13: Replace `pageHideTimeout` with `backgroundTimeout` and `timeout`. Allow to set them in constructor & data/url setters. - Address WICG#14: Rename `isPending` to `pending` and specify its behaviors. - Address WICG#14: Keep the low-level sync API, and mark it as chosen. - Fix WICG#6: Add `PendingGETBeacon` and `PendingPOSTBeacon`.
cc @philipwalton @fergald PTAL. Please also suggest better naming than |
- WICG#16 (comment) Specify when a timer will start for `timeout`
- `pageHideTimeout` - Replace pageHideTimeout with `backgroundTimeout` and `timeout`. - Allow to set them in constructor & via property setters. - `isPending` - Rename isPending to `pending` and specify its behaviors. - `setData(data)` - Remove setData(data) from base class PendingBeacon. - Add subclass `PendingGetBeacon` which supports `setURL(url)`. - Also define a new mojom method `setRequestURL(url)` to help update browser-side beacon. - Add subclass `PendingPostBeacon` which supports `setData(data)`. See [the pull request][1] or [explainer][2] for more details. [1]: WICG/pending-beacon#16 (comment) [2]: https://github.com/WICG/unload-beacon#readme Bug: 1293679 Change-Id: I8b73bdd3de7f5e8a3358564be52e2c0f2f6774de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3789544 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ming-Ying Chung <mych@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1031758}
I think in the case of
I think Tab A's map.company.com beacons should still be delivered because
In general I would really like to not impose restrictions on beacon that are not present already because all that does is keep devs doing things the hard way which also tends to be wasteful of user resources. |
- `pageHideTimeout` - Replace pageHideTimeout with `backgroundTimeout` and `timeout`. - Allow to set them in constructor & via property setters. - `isPending` - Rename isPending to `pending` and specify its behaviors. - `setData(data)` - Remove setData(data) from base class PendingBeacon. - Add subclass `PendingGetBeacon` which supports `setURL(url)`. - Also define a new mojom method `setRequestURL(url)` to help update browser-side beacon. - Add subclass `PendingPostBeacon` which supports `setData(data)`. See [the pull request][1] or [explainer][2] for more details. [1]: WICG/pending-beacon#16 (comment) [2]: https://github.com/WICG/unload-beacon#readme Bug: 1293679 Change-Id: I8b73bdd3de7f5e8a3358564be52e2c0f2f6774de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3789544 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ming-Ying Chung <mych@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1031758} NOKEYCHECK=True GitOrigin-RevId: d65b7474fc01ad30750fbbca7ad55b09b8070157
pageHideTimeout
support additional events #13:pageHideTimeout
withbackgroundTimeout
andtimeout
.setData()
orsetURL()
.isPending
's value is unclear after deactivate() #11: RenameisPending
topending
and specify itsbehaviors.
setData(data)
only support POST request #6:PendingGETBeacon
which supportssetURL(url, options)
.PendingPOSTBeacon
which supportssetData(data, options)
.setData(data)
from basePendingBeacon
.