-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade styled components v6 xstyled v4 #2524
base: main
Are you sure you want to change the base?
Conversation
564bf01
to
d087006
Compare
b33f082
to
98edc6c
Compare
98edc6c
to
d03a13f
Compare
@@ -63,7 +63,7 @@ const Home = () => { | |||
return ( | |||
<Box as="main" p="xl"> | |||
<Box margin="0 auto" maxWidth={600}> | |||
<Text color="secondary-red" textAlign="center" variant="subtitle-md"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @theo-mesnil what is the secondary-red
color? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An invention (it's the next colors but it's not ok here :D)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade guide
styled-components
to v6@xstyled/styled-components
to v4@types/styled-components
(types are now included instyled-components@6.*.*
)styled.whateverBox
instead ofstyled.div
with${system}
pattern (The definition of the return type of the styled function has change)To fix the error, you need to use the following pattern:
toHaveStyleRule
on test by adding spaces onrgb/rgba
keywords:Other breaking changes:
@welcome-ui/system
theme
cf 1736741